[hotfix][ci] Set AWS end-to-end tests to run on all push #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlteoh37
force-pushed
the
test_e2e_creds
branch
3 times, most recently
from
ee43a43
to
84ea552
Compare
dannycranmer
reviewed
Oct 2, 2023
.github/workflows/common.yml
Outdated
| @@ -120,7 +115,7 @@ jobs: | |||
| mvn clean | |||
|
|
|||
| - name: Run AWS e2e tests | |||
| if: ${{ inputs.run_aws_end_to_end_test }} | |||
| if: ${{ github.ref == 'refs/heads/main' }} | |||
There was a problem hiding this comment.
What happens if the remote branch is called main ?
There was a problem hiding this comment.
I thought about this, but I think the label is has the committer name in it. i.e. hlteoh37:main.
Let me check :D
There was a problem hiding this comment.
Seems like for pull requests, it is called something else entirely.
https://github.com/apache/flink-connector-aws/actions/runs/6378810397/job/17310103016?pr=101
hlteoh37
force-pushed
the
test_e2e_creds
branch
from
84ea552
to
2c139e1
Compare
hlteoh37
changed the title
dannycranmer
approved these changes
Oct 2, 2023
dannycranmer
approved these changes
Oct 2, 2023
dannycranmer
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving))